[Feat]: Add Dynamo E2E test profile with GPU support #789
+3,291
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abdallahsamabd
force-pushed
the
feat/659
branch
from
e4d5f12 to
56977b0
Compare
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
abdallahsamabd
force-pushed
the
feat/659
branch
2 times, most recently
from
95b5e13 to
a225953
Compare
Collaborator
|
@abdallahsamabd this is cool! Do you happen to have a demo too? We can add the demo to the YouTube channel. |
Author
|
I will create a demo video soon, that will show running the full Dynamo/profile flow which will run all written tests as well, and will show the Dynamo components that being deployed, also will show some manual requests. |
abdallahsamabd
changed the title
abdallahsamabd
force-pushed
the
feat/659
branch
6 times, most recently
from
5edfcb0 to
04675ff
Compare
- Add Dynamo profile for GPU-enabled disaggregated vLLM deployment - Add GPU setup integration in Kind cluster (nvidia runtime, library copy, device plugin) - Add DynamoGraphDeployment with Frontend + Prefill + Decode workers - Add Dynamo test cases (health check, GPU utilization, performance) - Fix relative paths in runner.go and profile.go - Re-enable teardown after tests - Remove Dynamo from CI matrix (requires GPU, run manually) - Update README with GPU requirements (3 GPUs minimum) - Remove unused files (namespace.yaml, kustomization.yaml, nvkind-gpu-setup-rhel.md) Requires: VM with 3+ NVIDIA GPUs Run: make e2e-test-dynamo Signed-off-by: abdallahsamabd <[email protected]>
abdallahsamabd
force-pushed
the
feat/659
branch
from
04675ff to
be02009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: VM with 3+ NVIDIA GPUs
Run: make e2e-test-dynamo
FILL IN THE PR DESCRIPTION HERE
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews